Poll & wikilink theming broken.

Questions, comments, and suggestions about this site should go here.
Post Reply

The answer:

True
4
24%
False
1
6%
Contradiction
12
71%
 
Total votes: 17

User avatar
Combuster
Member
Member
Posts: 9301
Joined: Wed Oct 18, 2006 3:45 am
Libera.chat IRC: [com]buster
Location: On the balcony, where I can actually keep 1½m distance
Contact:

Poll & wikilink theming broken.

Post by Combuster »

It appears that some board styles cause the message "The submitted form was invalid" upon casting a vote. This applies at least to the MegaTokyo theme (which seems to be popular among the senior members), and maybe others.

You can get around the problem by switching your theme to prosilver (phpbb's bundled theme), but of course I'd like to see this fixed. Poll attached for testing purposes

Edit: As posted below, in some other themes, it appears that there's also no link to the Main_Page

Checklist:
SFCentar: no Wiki link.
eTech dark green: no Wiki link.
OMG Ponies: no Wiki link.
Voting: fixed
Last edited by Combuster on Fri Dec 24, 2010 3:38 am, edited 4 times in total.
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]
User avatar
piranha
Member
Member
Posts: 1391
Joined: Thu Dec 21, 2006 7:42 pm
Location: Unknown. Momentum is pretty certain, however.
Contact:

Re: Poll theming broken.

Post by piranha »

Doesn't work in Blue Moon either.

-JL
SeaOS: Adding VT-x, networking, and ARM support
dbittman on IRC, @danielbittman on twitter
https://dbittman.github.io
computafreak
Member
Member
Posts: 76
Joined: Sun Dec 14, 2008 1:53 pm

Re: Poll theming broken.

Post by computafreak »

Works for me using SkyBlue
User avatar
Brendan
Member
Member
Posts: 8561
Joined: Sat Jan 15, 2005 12:00 am
Location: At his keyboard!
Contact:

Re: Poll theming broken.

Post by Brendan »

Hi,

The poll worked fine for me, using the "OMG Ponies" theme... :-)

[EDIT]
Ok, I just realised that for the "OMG Ponies" theme there is no link to the Wiki. I wonder if this explains why so many new members ask questions without checking the wiki first? :roll:
[/EDIT]


Cheers,

Brendan
For all things; perfection is, and will always remain, impossible to achieve in practice. However; by striving for perfection we create things that are as perfect as practically possible. Let the pursuit of perfection be our guide.
User avatar
Solar
Member
Member
Posts: 7615
Joined: Thu Nov 16, 2006 12:01 pm
Location: Germany
Contact:

Re: Poll theming broken.

Post by Solar »

SFCentar: Voting works, no Wiki link.
blackbox_blue: Voting broken, Wiki link available.
eTech dark green: Voting broken, no Wiki link.
subsilver: Voting works, Wiki link available.
mega-tokyo: Voting broken, Wiki link available.
Every good solution is obvious once you've found it.
User avatar
Combuster
Member
Member
Posts: 9301
Joined: Wed Oct 18, 2006 3:45 am
Libera.chat IRC: [com]buster
Location: On the balcony, where I can actually keep 1½m distance
Contact:

Re: Poll & wikilink theming broken.

Post by Combuster »

And I thought only Alboin was using the ponies theme... Then again, I don't think the noobs are that likely to use it, as well as the fact that they do get the link before they register (since prosilver does work).

Updated the first post with the buglist so far.
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]
User avatar
piranha
Member
Member
Posts: 1391
Joined: Thu Dec 21, 2006 7:42 pm
Location: Unknown. Momentum is pretty certain, however.
Contact:

Re: Poll & wikilink theming broken.

Post by piranha »

They'd use it more if it were the default theme...*ahem* :D

-JL
SeaOS: Adding VT-x, networking, and ARM support
dbittman on IRC, @danielbittman on twitter
https://dbittman.github.io
User avatar
chase
Site Admin
Posts: 710
Joined: Wed Oct 20, 2004 10:46 pm
Libera.chat IRC: chase_osdev
Location: Texas
Discord: chase/matt.heimer
Contact:

Re: Poll & wikilink theming broken.

Post by chase »

MegaTokyo/template/viewtopic_body.html was missing a {S_FORM_TOKEN}. It was missing from the subsilver2 3.0.1 version of the file so any theme that began as a modified version of that theme was also missing the entry. Voting looks to be working on all themes now, if not then let me know.

The themes/templates have changed enough that we probably need to rebuild them. I tried a quick merge of the current css subsilver2-megatokyo differences and the result was unusable. We probably need to diff the 3.0.1 version of subsilver2 and MegaTokyo and try to build an updated version of MegaTokyo with 3.0.8 subsilver2 as the basis.
User avatar
Combuster
Member
Member
Posts: 9301
Joined: Wed Oct 18, 2006 3:45 am
Libera.chat IRC: [com]buster
Location: On the balcony, where I can actually keep 1½m distance
Contact:

Re: Wikilink theming broken.

Post by Combuster »

Thanks for fixing the poll
"Certainly avoid yourself. He is a newbie and might not realize it. You'll hate his code deeply a few years down the road." - Sortie
[ My OS ] [ VDisk/SFS ]
Post Reply